Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance stats #1393

Closed
1 of 29 tasks
dukio opened this issue May 13, 2022 · 2 comments · Fixed by #2084
Closed
1 of 29 tasks

Enhance stats #1393

dukio opened this issue May 13, 2022 · 2 comments · Fixed by #2084
Assignees
@dukio
Labels
enhancement New feature or request

Comments

@dukio
Copy link
Contributor

dukio commented May 13, 2022 •
edited
Loading

This issues serves the purpose to track all things that could be improved or implemented to make stats more accurate.

This is an ever evolving list

EHP?

Also see lib.js->getStats()
@dukio dukio added the enhancement New feature or request label May 13, 2022
This was referenced May 13, 2022
Closed
Merged
@dukio dukio self-assigned this May 13, 2022
@dukio dukio mentioned this issue May 25, 2022
Closed
@dukio dukio mentioned this issue Jun 8, 2022
Merged
@DuckySoLucky
Copy link
Member

DuckySoLucky commented Sep 23, 2022 •
edited
Loading

Hey, letting u know that this stuff has been already done in QwackAPI. Accuracy isn't 100% there are some stuff which are not possible to make like Magic Find and Wisdom from Booster Cookie (Impossible to detect if player has an cookie or not, not in API I think, not 100% sure) and 1-10 Intelligence (Defuse Kit, not in API). Example of stats can be found Here.I have tested this on multiple profiles and accounts, accuracy is like 99% without taking in fact impossible stuff, mostly because Hypixel's WIKI's reforge information isn't 100% accurate.

I made this recently so code isn't really clean or fully optimized. I have to update some stuff like calculation so it uses names of items instead of IDs and stuff like that, but other than that it's pretty much complete

I'm planning to slowly integrate it into SkyCrypt, but recently I have been kind of busy so no ETA yet. Making this in case someone wants to work on this so he doesn't have to write everything again for no reason

@DuckySoLucky
Copy link
Member

DuckySoLucky commented Sep 28, 2022 •
edited
Loading

Completion

  • Bestiary Level (Health)
  • Cake Bag (Health)
  • Catacombs Level (Health)
  • Reaper Peppers (Health)
  • Unique Pets (Magic Find)
  • Jacob's Farming Shop (Farming Fortune)
  • Permanent stats from Wither Essence Shop
  • Fairy Souls Replaced by levels, waiting for Hypixel
  • Slayer Level Up Bonus
  • Slayer Tier Completions (Combat Wisdom
  • Skill Level up (Carpentry is missing)
  • Equipment
  • Active Accessories
  • Custom accessory abilities (Day/Night Crystal)
  • Current Reforge
  • HOTM (Mining Fortune, Speed, Mining Wisdom)
  • Harp (Intelligence)
  • Armor
  • Custom Armor Abilities (Superior, Young, Obsidian Chestplate etc..)
  • Active Pet
  • Custom Pet Abilities (Whale pet health multiplier, Ender Dragon stats Multiplier etc..)
  • Active Potion Effects

Somehow find out if player has cookie or not. Otherwise 25 Wisdom on each stat and 15 Magic Find will be missing

@DuckySoLucky DuckySoLucky mentioned this issue Oct 1, 2022
Closed
@DuckySoLucky DuckySoLucky mentioned this issue Aug 8, 2023
Closed
@DuckySoLucky DuckySoLucky mentioned this issue Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dukio dukio

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@dukio @DuckySoLucky