From ca3c8873eb2977f2b7fc0de7526d5905c22d4cc6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B3n=20Bjarni=20Bjarnason?= Date: Wed, 26 Jun 2024 11:44:54 +0000 Subject: [PATCH] throw error if unable to write json variables --- .../inc/public/tfc/ipc/details/dbus_server_iface.hpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libs/ipc/inc/public/tfc/ipc/details/dbus_server_iface.hpp b/libs/ipc/inc/public/tfc/ipc/details/dbus_server_iface.hpp index 452b1d64e2..f78e91a43b 100644 --- a/libs/ipc/inc/public/tfc/ipc/details/dbus_server_iface.hpp +++ b/libs/ipc/inc/public/tfc/ipc/details/dbus_server_iface.hpp @@ -286,7 +286,7 @@ class ipc_manager_server { auto const write{ glz::write_json(ipc_manager_->get_all_signals()) }; if (!write) { fmt::println(stderr, "Failed to write signals to json: {}", format_error(write.error())); - return std::string{}; + throw dbus_error("Failed to write signals to json"); } return write.value(); }); @@ -295,8 +295,8 @@ class ipc_manager_server { std::string(consts::slots_property), sdbusplus::vtable::property_::emits_change, [&](const auto&) { auto const write{ glz::write_json(ipc_manager_->get_all_slots()) }; if (!write) { - fmt::println(stderr, "Failed to write signals to json: {}", format_error(write.error())); - return std::string{}; + fmt::println(stderr, "Failed to write slots to json: {}", format_error(write.error())); + throw dbus_error("Failed to write slots to json"); } return write.value(); }); @@ -305,8 +305,8 @@ class ipc_manager_server { std::string(consts::connections_property), sdbusplus::vtable::property_::emits_change, [&](const auto&) { auto const write{ glz::write_json(ipc_manager_->get_all_connections()) }; if (!write) { - fmt::println(stderr, "Failed to write signals to json: {}", format_error(write.error())); - return std::string{}; + fmt::println(stderr, "Failed to write connections to json: {}", format_error(write.error())); + throw dbus_error("Failed to write connections to json"); } return write.value(); });