Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

line_items_for filter missing #744

Closed
bakura10 opened this issue Sep 17, 2023 · 5 comments
Closed

line_items_for filter missing #744

bakura10 opened this issue Sep 17, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@bakura10
Copy link

Hi,

The line_items_for filter is currently raising an error in the linter: https://shopify.dev/docs/api/liquid/filters/line_items_for
Is it possible to add it ? :)

Thanks.

@bakura10 bakura10 added the bug Something isn't working label Sep 17, 2023
@bakura10
Copy link
Author

bakura10 commented Oct 5, 2023

Any news on this? Unfortunately it seems that each time new filters are released, it takes months for them to be integrated into the platform.

@charlespwd
Copy link
Contributor

charlespwd commented Oct 5, 2023

So we switched to an automatic workflow for this. It seems like the data is there:
https://github.com/Shopify/theme-liquid-docs/blob/main/data/filters.json#L74

And IIRC, there's a job somewhere that pulls the latest docs on check run. In which context do you see the issue? CLI, extension? What version?

@charlespwd
Copy link
Contributor

Ah derp the flag is off by default:

return unless @update_docs

Try running the CLI with the --update-docs flag. That should fix it for you!

@charlespwd
Copy link
Contributor

FYI we're in the process of migrating to the TypeScript based implemetation in Shopify/theme-tools. It's fixed over there.

We're already in dev preview in the VS Code extension (shopifyLiquid.themeCheckNextDevPreview: true) and we're coming to the CLI very soon.

@bakura10
Copy link
Author

bakura10 commented Oct 5, 2023

I was using the CLI, and adding --update-docs flag fixed it! Thanks a lot :)

@bakura10 bakura10 closed this as completed Oct 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants