Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Add system translation for spam_detection.disclaimer_html #265

Closed
gideonb opened this issue Apr 20, 2021 · 3 comments · Fixed by #266
Closed

Add system translation for spam_detection.disclaimer_html #265

gideonb opened this issue Apr 20, 2021 · 3 comments · Fixed by #266
Labels
bug Something isn't working

Comments

@gideonb
Copy link
Contributor

gideonb commented Apr 20, 2021

Context

The Recaptcha V3 update added a legal requirement for Recaptcha-protected contact forms to display a link to Recaptcha's terms and conditions. On stores with a contact form section on the homepage, this would add a sticky Recaptcha logo to the bottom corner of the page, often blocking chat widgets or other features.

Needless to say, the legally required sticky blue recycling logo is not a popular feature.

The fix is to add a translation to the contact form that cleverly injects a link to the terms and conditions. That code is:
{{ 'shopify.online_store.spam_detection.disclaimer_html' | t }}

When that code is present inside the {% form %} object the sticky recycling logo goes away.

Here's a docs link if you don't want to take my word for it:
https://shopify.dev/docs/themes/recaptcha-v3

Issue

Theme-check does not recognize shopify.online_store.spam_detection.disclaimer_html to be a system translation so it throws the following error:
image

@charlespwd
Copy link
Contributor

I absolutely take your words for it.

We don't have a good solution to sync new keys as they come in. Will add!

@charlespwd charlespwd added the bug Something isn't working label Apr 20, 2021
@charlespwd
Copy link
Contributor

Fixed in 0.8.1.

brew update
brew upgrade theme-check

@thagxt
Copy link

thagxt commented Feb 14, 2024

@charlespwd Not working for me:

Screenshot 2024-02-14 at 13 23 53

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants