-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version to v0.22.2 #595
Conversation
In the interest of maintaining a clean commit history, would you mind squashing these commits into one? |
Does bumping this version automatically trigger a GH release once merged to main? Or is there a separate process for that |
No we have to manually relaese it by creating a tag, ref: https://github.com/Shopify/kubeaudit/blob/main/docs/release.md |
cmd/commands/VERSION
Outdated
@@ -1 +1 @@ | |||
0.22.1 | |||
0.23.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: shouldn't this be a patch bump? we're not introducing new functionality and it's backwards compatible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this isn't a bug fix, adding a deprecation notice (considered a minor update without breaking functionality), I thought the next version should be v0.23.0. Could be changed to a patch bump too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dani-santos-code changed it into patch bump now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, it's not a bug fix. It seems debatable, though. 😬 Found some discussions on StackOverflow around this and I don't see a clear consensus:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a blocker at all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! can we update the title of the PR? thanks!
Releasing a new version of Kubeaudit for the depracation notice.
Related issue:#593 (comment)