Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up extension config #4532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

isaacroldan
Copy link
Contributor

WHY are these changes introduced?

When loading the extension configuration we were injecting some extra properties that are not expected by the contracts.
The extension config should reflect exactly what's in the toml, and nothing else.

WHAT is this pull request doing?

Remove extensions and path from the extension config.

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
72.74% (-0% 🔻)
8484/11664
🟡 Branches
69.43% (+0.02% 🔼)
4154/5983
🟡 Functions 71.55% 2201/3076
🟡 Lines
73.07% (-0% 🔻)
8028/10987
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / update-extension.ts
64.86% (-3.71% 🔻)
54.55% 60%
68.75% (-4.58% 🔻)

Test suite run success

1928 tests passing in 872 suites.

Report generated by 🧪jest coverage report action from a2c1925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant