Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeated email warnings about deprecated Storefront AP field, 'Money scalar' #833

Open
Mesuva opened this issue Dec 15, 2022 · 1 comment

Comments

@Mesuva
Copy link

Mesuva commented Dec 15, 2022

I'm using version 2.2.1 of buy-button.js on my sites, which I believe is the latest available.

For the last few months I've been getting emails like this from Shopify:

Hi There,

One or more of your custom apps have made deprecated API calls in the last 30 days. Support for these versions will be removed on January 1, 2023 to allow for continued infrastructure improvements. Please update the apps listed below to
API version 2022–07 or later to ensure they continue to function correctly:

Shop: REMOVED

Breaking changes affecting REMOVED

Several fields on the Storefront API were marked as deprecated
Shop: REMOVED

Breaking changes affecting Website Integration

Several fields on the Storefront API were marked as deprecated

I've only recently found via the deprecated_api_calls endpoint the actual specific warnings. Here's one of them:

As of 2022-10, the Money scalar is being removed from the Storefront API, and fields with V2 ({field}V2: MoneyV2) suffixes are being deprecated. Please check the changelog notes for full details of the change.

Here's the notes: https://shopify.dev//changelog//changes-to-graphql-api-moneyv2-related-fields

I though this might be down to my usage of the moneyFormat option when initialising the cart and product buttons, but I'm suspecting that it's more through the entire buy-button codebase where 'Money' is being referred.

I believe this comes fromo the inclusion of version of 2.16.1 shopify-buy:
https://github.com/Shopify/buy-button-js/blob/master/package.json#L108

Should this be bumped to version 2.17.1, and a new release put out urgently?
Version 2.17.1 has removed Money scalar it appears.

I've tried a build myself with 2.17.1 in place of shopify-buy, and appears to pass all tests, but I'm thinking this needs to be officially done.

@scald
Copy link

scald commented Dec 20, 2022

+1

scald added a commit to scald/buy-button-js that referenced this issue Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants