Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block commiting if the linter threw some warning #10

Open
yetiasg opened this issue Apr 27, 2023 · 1 comment · May be fixed by #20
Open

Block commiting if the linter threw some warning #10

yetiasg opened this issue Apr 27, 2023 · 1 comment · May be fixed by #20
Assignees

Comments

@yetiasg
Copy link
Contributor

yetiasg commented Apr 27, 2023

Short overview

Commits can successfully pass only if the linter didn't throw any warning

ToDo

Find some solution that runs linter after running a git commit command and check if the linter threw some warning, if so, abort committing

@yetiasg yetiasg self-assigned this Apr 27, 2023
@PoslinskiNet
Copy link
Member

https://pre-commit.com/ ... but I would consider CI approach instead as a separate step - github action. Maybe as an extension to https://github.com/Selleo/repolisher

@yetiasg yetiasg linked a pull request May 9, 2023 that will close this issue
@yetiasg yetiasg linked a pull request May 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants