Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predefined custom class does not export properly #225

Open
wakinpang opened this issue Oct 10, 2022 · 5 comments
Open

Predefined custom class does not export properly #225

wakinpang opened this issue Oct 10, 2022 · 5 comments

Comments

@wakinpang
Copy link

we defined a custom class like this
image
and use it as property, we found that there is no hierarchy relationship between class and members, they exported to same layer like this
image
member and class are in the same level, and sometimes members are missing(there is no flag member in above pic)
is this a bug or just by design?

@Seanba
Copy link
Owner

Seanba commented Oct 12, 2022

Hi there, @wakinpang. These custom classes were not a feature when I first put ST2U together and I didn't know about them until you posted this issue.

I'll study this some more and work on implementing it into my tool. Thanks for letting me know.

@wakinpang
Copy link
Author

Hello @Seanba , Thanks for replying, we are trying to resolve this by adding all class's data and structure into CustomeProperty 's m_Value with json format. so when we export a class property, there is only one custom property represents the class, the member and data are in the Value box

@Seanba
Copy link
Owner

Seanba commented Oct 15, 2022

@wakinpang can you send me your exported Object Types XML file? It will help me in testing. Thanks.

@Seanba Seanba reopened this Oct 15, 2022
@wakinpang
Copy link
Author

<?xml version="1.0" encoding="UTF-8"?>
<objecttypes>
 <objecttype name="Script" color="#aa0000">
  <property name="CorrespondType" type="int" propertytype="TriggerType" default="0"/>
  <property name="ScriptFile" type="file" default=""/>
 </objecttype>
 <objecttype name="Test" color="#00557f">
  <property name="flag" type="int" propertytype="TriggerType" default="0"/>
  <property name="type" type="int" propertytype="ObjectType" default="0"/>
 </objecttype>
</objecttypes>

@Seanba Of course, it's simple, the TriggerType and ObjectType are both enum.

@yuwenhuisama
Copy link

Hi @Seanba , we commit a PR to fix this bug, but it seems like a breaking change, pls have a review. #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants