Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I Want to Contribute, How Can i Do That? #1

Open
sDos280 opened this issue Feb 11, 2023 · 5 comments
Open

I Want to Contribute, How Can i Do That? #1

sDos280 opened this issue Feb 11, 2023 · 5 comments

Comments

@sDos280
Copy link
Contributor

sDos280 commented Feb 11, 2023

Hi, @ScriptLineStudios.
after looking around GitHub I found your project, and I really like its idea.

I would really like to contribute to that project. Are there some conventions that I need to follow to contribute?

some background about me: I am a c/c++/python programmer, I am one of the raylib contributors, and I really like to contribute to new graphic libraries, especially ones that able to run on web

@sDos280
Copy link
Contributor Author

sDos280 commented Feb 11, 2023

for example, one thing I would like to do is refactor the draw function.
for example, the waphics_draw_circle uses this expression dist((int)circle.x, (int)circle.y, (int)_x, (int)_y) < circle.r to check if the "current pixel" is in the circle, but instead of doing that you can check if the distance squared is less then the circle's radius squared (circle.x - x)*(circle.x - x) + (circle.y - y)*(circle.y - y) < circle.r * circle.r

@sDos280
Copy link
Contributor Author

sDos280 commented Feb 11, 2023

and i seem to get an error when i try to use the CIRCLE macro
#define CIRCLE(x, y, r) waphics_rectangle_new(x, y, r) that seem to be the issue.
i think you meant it to be:
#define CIRCLE(x, y, r) waphics_circle_new(x, y, r)

@ScriptLineStudios
Copy link
Owner

Hello! Thanks for pointing out the issues, I was actually just working on fixes for them lol. As you can probably tell, this project is still quite early in development, but I would love contributes :D as for conventions I am quite relaxed.

Thanks for showing interest in the project!

@sDos280
Copy link
Contributor Author

sDos280 commented Feb 11, 2023

thanks for the replay!!

is that will be ok if I will open some GitHub issues regarding some errors/issues that I encountered?

@ScriptLineStudios
Copy link
Owner

@sDos280 yes that would be great thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants