Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parsec icon to Resana mountpoint directories #208

Open
mmmarcos opened this issue Jun 30, 2023 · 2 comments
Open

Add Parsec icon to Resana mountpoint directories #208

mmmarcos opened this issue Jun 30, 2023 · 2 comments
Assignees
Labels
Milestone

Comments

@mmmarcos
Copy link
Collaborator

mmmarcos commented Jun 30, 2023

On Windows, workspaces are mounted into the following directories:

  • HOME/Resana Secure/<regular_workspace>
  • HOME/<personal_workspace> (i.e. HOME/Drive)

It should be nice to display the Parsec icon for this directories (much like the Windows special folders Desktop, Pictures, Music, etc.). This can probably be done by tweaking the Windows Registry during Resana Secure installation.

See #96
See #207

@TimeEngineer
Copy link

TimeEngineer commented Jul 21, 2023

See:
https://learn.microsoft.com/en-us/windows/win32/shell/how-to-customize-folders-with-desktop-ini
https://www.groovypost.com/explainer/what-is-desktop-ini-on-windows
Every folder has a desktop.ini file hidden, so we can modify this file when a workspace is mounted

@mmmarcos
Copy link
Collaborator Author

mmmarcos commented Jul 25, 2023

@TimeEngineer Yes! that will be useful for the Resana Secure directory because the file would be outside the workspaces:

  • HOME/Resana Secure/Desktop.ini <-- OK, outside the workspaces
  • HOME/Resana Secure/alice_workspace/ <-- workspace
  • HOME/Resana Secure/bob_workspace/ <-- workspace

However, the "personal" workspace is different because the Desktop.ini file would need to be inside the workspace:

  • HOME/Mon_Drive_Sec/Desktop.ini

The implementation seems complicated because the code (WinFSPOperations?) would need to check if the path being read contains Desktop.ini AND it is at the root directory, and if that is the case return a fake file pointer to the file with the required contents.

If its possible tweaking the Window's Registry, it seems a better approach because it does not require to add or test a special case in the mountpoint code.

@Landeers Landeers modified the milestones: 0.14, 0.15 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants