Towards Common Perform step #717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,7 +51,28 @@ alg_cache(alg::SSPRK22,u,rate_prototype,uEltypeNoUnits,uBottomEltypeNoUnits,tTyp | |||
| step_limiter!::StepLimiter | |||
| end | |||
|
|
|||
| struct SSPRK33ConstantCache <: OrdinaryDiffEqConstantCache end | |||
There was a problem hiding this comment.
you can probably make this cache and the previous the same?
There was a problem hiding this comment.
we need to be careful about the ones that have a different interpolation though.
There was a problem hiding this comment.
Yeah we can have same caches but different constructors (I mean using inheritence).
|
Shifting to SArrays makes us very close to our previous performance stats, atleast for this small script: using BenchmarkTools, OrdinaryDiffEq
f(u,p,t) = 1.01*u
u0=1/2
tspan = (0.0,1.0)
prob = ODEProblem(f,u0,tspan)
@btime sol = solve(prob,SSPRK33(),reltol=1e-8,abstol=1e-8,dt=0.01)Master: PR: |
|
Switch broadcasts to |
|
Ref: #233 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very rough implementation for common perform step for SSPRK22 and SSPRK33, which I am expanding to more algorithms.
This implementation is not at all feasible to be merged as it allocates in constant cache. I am learning the metaprogramming in Julia to know what all is possible for us.
Ideas I am thinking:
@unpackwhich if an entry is not found in the object, assigns some specific default value. Like ifc0doesn't exist in cache, it should be set to1.0.