Add Order Adaptivity to Radau #2478
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r package downstream, (keep existing compat)
…n/2024-09-20-12-33-04-980-00553399318 CompatHelper: add new compat entry for OrdinaryDiffEq at version 6 for package downstream, (keep existing compat)
| @@ -24,8 +24,9 @@ | |||
| q | |||
| end | |||
|
|
|||
| function step_accept_controller!(integrator, controller::PredictiveController, alg, q) | |||
| function step_accept_controller!(integrator, controller::PredictiveController, alg::Union{RadauIIA3, RadauIIA5, RadauIIA9}, q) | |||
There was a problem hiding this comment.
I think this restriction on the alg isn't desired.
There was a problem hiding this comment.
why? don't we have to specify which controller each algorithm should use?
There was a problem hiding this comment.
PredictiveController is not Radau-specific.
There was a problem hiding this comment.
the controller isn't set by dispatch. It's user configurable with the default set in algorithms.jl .
| tab = adaptiveRadauTableau(uToltype, constvalue(tTypeNoUnits), num_stages) | ||
|
|
||
| min = alg.min_num_stages | ||
| max = alg.max_num_stages |
There was a problem hiding this comment.
rename min_stages and max_stages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.