Make W_transform always true #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this is a good idea. The same would need to be done on StochasticDiffEq for this to go through. |
oscardssmith
added a commit
to SciML/StochasticDiffEq.jl
that referenced
this pull request
Aug 2, 2024
the solvers already use the W-transform so we should be testing with it (especially because I'm about to delete the non-W-transformed version in SciML/OrdinaryDiffEq.jl#2297)
oscardssmith
force-pushed
the
os/always-w-transform
branch
from
5847ba1
to
2c6fc28
Compare
oscardssmith
force-pushed
the
os/always-w-transform
branch
from
2c6fc28
to
8587bad
Compare
|
Now that Rosenbrock23 is updated, I think this should be ready to go. Let's see if CI agrees. |
oscardssmith
force-pushed
the
os/always-w-transform
branch
2 times, most recently
from
623e688
to
a22c77d
Compare
|
ok, this should now be ready to merge. |
oscardssmith
changed the title
|
ah it looks like ODEExtrapolation also is currently written with transform false. |
oscardssmith
force-pushed
the
os/always-w-transform
branch
from
42c5452
to
5a67651
Compare
oscardssmith
force-pushed
the
os/always-w-transform
branch
from
19197ce
to
e042495
Compare
|
CI green. Merge? |
ChrisRackauckas
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rosenbrock23 and Rosenbrock32 need updating to the W_transform versions, but other than that, this PR removes ~200 lines of complexity for free.