Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosenbrock-W method docstrings #2289

Open
termi-official opened this issue Jul 19, 2024 · 2 comments
Open

Rosenbrock-W method docstrings #2289

termi-official opened this issue Jul 19, 2024 · 2 comments
Labels

Comments

@termi-official
Copy link
Contributor

termi-official commented Jul 19, 2024

The doc categorization for Rosenbrock-W (after Wolfbrandt) are messed up on the latest release and need to be rolled back before f8f8307 see #2236 (comment) for more discussion and #2236 (comment) for the concrete action to take for the doc strings functions.

@gstein3m
Copy link
Contributor

Maybe Table 1 in https://github.com/hbrs-cse/RosenbrockMethods/blob/main/paper/JuliaPaper.pdf can help in deciding whether it is a W method. Note that the W property usually only refers to ODEs and not to DAEs.
However, the W property does not appear to be utilized in the implementation. The user must then specify an approximated Jacobian matrix themselves.

@ChrisRackauckas
Copy link
Member

However, the W property does not appear to be utilized in the implementation.

It's somewhat implicit. If someone uses autodiff=false, the non-W methods can have some deterioration at lower tolerances. Autodiff makes that go away though, which is the most common option.

The best way to use the W property is to come up with some W-reuse scheme between steps, but we haven't really explored that as much as we should have since the best methods have been the Rodas methods, which don't have the property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants