Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.46 introduces breaking change in complete #3118

Closed
isaacsas opened this issue Oct 13, 2024 · 1 comment
Closed

9.46 introduces breaking change in complete #3118

isaacsas opened this issue Oct 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@isaacsas
Copy link
Member

isaacsas commented Oct 13, 2024

https://github.com/SciML/ModelingToolkit.jl/blame/fcad04c5bef4f27de1245f15b20f6928952cb9fd/src/systems/abstractsystem.jl#L925-L933

This is a change in an exported API function that makes new assumptions on system properties / behavior that were not previously present. Shouldn't this be breaking? The need to explicitly opt JumpSystems out of this change seems telling -- isn't that indicative that this is breaking for anything but an ODE/SDE system? Other system types defined outside of MTK will now have to dispatch and create their own version of this function or the newly introduced functions to avoid issues. Catalyst, for example, is now completely broken with this change on 9.46.

@isaacsas isaacsas added the bug Something isn't working label Oct 13, 2024
@ChrisRackauckas
Copy link
Member

Sorry, CI was just weird from the v1.11 so we missed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants