Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow looser thresholds for Animation speed #115

Closed
devkinetic opened this issue Mar 17, 2022 · 3 comments
Closed

Allow looser thresholds for Animation speed #115

devkinetic opened this issue Mar 17, 2022 · 3 comments
Labels
feature request New feature or request

Comments

@devkinetic
Copy link

The Idea

It would be cool if we could, for example, set a threshold of 250ms. I was trying to go for something jazzed up, but still snappy, 500ms seemed slow, and it felt even more sluggish when I enabled animations for dialog boxes.

I propose to either replace the slider with a number field, or allow the sliders to go down to at least 250ms.

The Alternatives

Modify the resource files for the animations to have a threshold of 250ms and then re-enabled your extension. In short there- there is no alternative without a code update.

@devkinetic devkinetic added the feature request New feature or request label Mar 17, 2022
@Schneegans
Copy link
Owner

Thanks for the suggestion! I'll reduce the limits for all effects.

In the meantime, you can also use this command to set the animation times to arbitrary values. Just replace energize-a with your desired effect name!

gsettings --schemadir ~/.local/share/gnome-shell/extensions/[email protected]/schemas set org.gnome.shell.extensions.burn-my-windows energize-a-animation-time 200

@Schneegans Schneegans added this to the Burn-My-Windows 13 milestone Mar 17, 2022
@devkinetic
Copy link
Author

devkinetic commented Mar 17, 2022

So while I was looking into this, I had a few ideas, but they were out of scope of my original need. thank you for that command, it will do exactly what I was looking for. I would presume I'd have to rerun it after editing an effect?

Anywho, here is what I think could be some new features, and If you think it's work it I will break out into tickets based on where things land:

  • Effect preset system - say for example I want to use energize-a for both open and close, but I want them to have different settings. the ability to make custom presets, and then instead select from those on the main settings page for open/close/dialog would allow more flexibility.
  • Allow choosing which effect, or effect preset is used on dialogs.
  • Expose the min/max animation thresholds as configurable settings, rather than within the resource files for each effect.

As you can see there is some overlap in scope across these items. Let me know what you think!

@Schneegans
Copy link
Owner

I had to reschedule this to BMW 14, as there was an important bug fix which needed to be released quickly.

The effect system sounds like a great idea. It would also align well with #89, #97 (if that one is possible), #108, and your idea about the dialogs. It would also solve #52, I guess. However, implementing this properly without making the UI more complicated, will be very challenging. I think it would be cool if you could open an issue for this Effect Preset System. Maybe you have already some ideas how this could look like!

And I think there is not need to expose the min/max animation durations once the limits are set a bit extremer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants