Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pset building inconsistency #34

Open
Saleciani opened this issue May 20, 2024 · 5 comments
Open

Pset building inconsistency #34

Saleciani opened this issue May 20, 2024 · 5 comments

Comments

@Saleciani
Copy link
Contributor

Currently, we are able to build a pset with and it will return an error if there are no funds in the wallet.

I do not understand if it is a lwk-dart bug or a a lwk inconsistency.

image image image

But:

We can set the fee to as low as possible and the pset will build, only when trying to publish we will get an error.

I think that the pset building should fail not just when the amount is very close to the maximum limit (so that there is no more amount for the fee) but also when the fee is too low for it to be published.

We should not be able o build a pset with a fee so low that won't be accepted by nodes.

What do you think?

@Saleciani
Copy link
Contributor Author

Update:

Pset building also returns insufficient funds error when we have

EX: 6000 sats in the wallet

Total fee: 260 sats

Sending amount 5600 sats.

This means that there is outstanding unspendable balance in the wallet 🤔

@i5hi
Copy link
Collaborator

i5hi commented May 20, 2024

yes, i reported this to lwk. we should get a patch soon.

we will also have drain soon.

@i5hi
Copy link
Collaborator

i5hi commented May 20, 2024

i've noticed right now a buffer of around 800 sats is required

@Saleciani
Copy link
Contributor Author

Saleciani commented May 20, 2024

Is this buffer supposed to be a feature or a bug? Do you know? 😃

@i5hi
Copy link
Collaborator

i5hi commented May 23, 2024

bug :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants