Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

add checks for exit codes where missing #4

Open
pondrejk opened this issue Aug 20, 2018 · 0 comments
Open

add checks for exit codes where missing #4

pondrejk opened this issue Aug 20, 2018 · 0 comments

Comments

@pondrejk
Copy link
Contributor

Backup (but also majority of other) tests rely solely on

assert "FAIL" not in result['stdout']

which can miss some problems, for example if a required command option changes, ansible_module.command produces no stdout therefore the above assert passes even if command actually fails. I suggest adding also assert result['rc'] == 0 wherever possible

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant