Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removed localStorage save but added an option to collapse groups on load #12

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

KittyGiraudel
Copy link
Member

I decided to remove the localStorage thingie. It adds some extra complexity that I feel is not worth the trouble. If someone really think we should keep the current sidebar state in localStorage, please feel free to ask.

Although I added a way to collapse all groups on load. This is done through the initialSidebarCollapse option (boolean). If someone has a better name for it, please share. :)

@KittyGiraudel
Copy link
Member Author

I need to run some extra tests on this.

@KittyGiraudel KittyGiraudel changed the title Removed localStorage save but added an option to collapse groups on load [WIP] Removed localStorage save but added an option to collapse groups on load Dec 31, 2014
@kaelig
Copy link
Contributor

kaelig commented Feb 3, 2015

I do think it should be kept in memory. Otherwise you might as well remove the collapsing feature altogether.

@KittyGiraudel
Copy link
Member Author

The thing is localStorage saving bothered me more than once. Maybe I only need to put some extra love to the implementation.

@Undistraction
Copy link

I'm not seeing an initialSidebarCollapse option in the theme settings. Has this subsequently been removed?

@dbox
Copy link

dbox commented Nov 9, 2015

+1 for collapsed on load.

@yoanmalie
Copy link

I need this feature :)
Any news ?

@KittyGiraudel
Copy link
Member Author

Good morning!

Unfortunately, I do not have time anymore to work on SassDoc. :(
I’ve seen @pascalduez do some commits every now and then, maybe he has some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants