Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links to hosted OVA files do not display in Markdown for README.md #178

Open
jcrew99 opened this issue Jan 7, 2023 · 2 comments
Open

Links to hosted OVA files do not display in Markdown for README.md #178

jcrew99 opened this issue Jan 7, 2023 · 2 comments

Comments

@jcrew99
Copy link

jcrew99 commented Jan 7, 2023

Hi there,

The links to the hosted ova files found in option 1 and 2 in the markdown readme are not displaying correctly. (tested with latest firefox and chrome)

This is what it looks like:
image

While it's find-able by looking at the page source, it did take me a second to realise what was going on.

I got curious as to what's going on and noticed that the reference doesn't display due to the double "" in the div style

i.e.
[<div style="text-align: center;"> Download SamuraiWTF for Hyper-V</div>](https://downloads-samuraiwtf-com.s3.us-west-2.amazonaws.com/SamuraiWTF_HyperV.zip)
Produces:

Download SamuraiWTF for Hyper-V

Where
[<div style="text-align: center;""> Download SamuraiWTF for Hyper-V</div>](https://downloads-samuraiwtf-com.s3.us-west-2.amazonaws.com/SamuraiWTF_HyperV.zip)
Produces:

<div style="text-align: center;""> Download SamuraiWTF for Hyper-V

So i would think that the double quotations is breaking the context or it's not supported on github markdown.
Either way, can it please be changed to something like displays the link like this:

Download SamuraiWTF for Hyper-V

From:
[<div style="text-align: center;">Download SamuraiWTF for Hyper-V</div>](https://downloads-samuraiwtf-com.s3.us-west-2.amazonaws.com/SamuraiWTF_HyperV.zip)

@JGillam
Copy link
Member

JGillam commented Jan 7, 2023 via email

@jcrew99
Copy link
Author

jcrew99 commented Jan 7, 2023

Yeah it's weird, i can't tell why it wouldn't work but i'm sure something changed that i haven't come across yet.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants