-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Zero config Exporter-> automatic discover the target. #54
Comments
Hmm, I'm not sure I understand. What did you find non-trivial? At the end of the day, |
yes setting a default value would be good! @stefanotorresi https://github.com/SUSE/sapnwbootstrap-formula/blob/master/netweaver/monitoring.sls My intent would be if we run like the
the same aspects we should work on the putting config values should be imho something advanced which is error prone for users |
Ok then, I guess we can make the UDS the default. This was not done initially because we didn't have UDS support in the first place, the default was TCP/IP on localhost. |
@stefanotorresi fair enough. I like personally your 1st suggestion, to change the precedence order. The E.g right now, we are advising the user to install our monitoring solution with formulas. We both know that this is not an elegant solution. Especially this might be not the best one for already deployed systems where we cannot know the state they are. Ideally if we can for all exporter we ship provide them with "0" configuration, we can then integrate our exporter here: https://github.com/SUSE/salt-formulas/tree/master/prometheus-exporters-formula I initially also wrote a PR for that, but then I realized that the I believe technically speaking, it is an anti-pattern the whole monitoring.sls state, which we historically did but I believe an exporter should be really self-sufficient. I think I'm tracking this in a meta issue/story. |
Consider also that changing this configuration precedence constitutes a backwards incompatible change. |
Ok true. I guess we know the problem now. I would think the implementation lets see later on. |
I do have though a bit and I found out that configuring the sap_host exporter is by user not trivial.
we don't offer the same experience we offer like the
ha_cluster_exporter
without any configuration needed by default.I think we can configure this all dynamically and retrieve the Instances automatically and serve them.
This is also a pattern in prometheus exporters
https://github.com/wrouesnel/postgres_exporter#automatically-discover-databases
prometheus-community/postgres_exporter#215
We might need to research also how we could offer such experience.
I think that using systemd It is still an elegant solution but we can always improve 😁
I'm adding as RFC because we might think.
The same would be valuable for
hanadb
exporter where we don't need all this config files. if we can implement it here.The text was updated successfully, but these errors were encountered: