-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demo accessibility with VoiceOver #578
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 14 days or if the stale label is not removed. |
This issue has been automatically closed because it has not had recent activity. |
We should have the standard slider pose as ours in our custom demo: .accessibilityRepresentation {
Slider(progressTracker: progressTracker)
} (possibly with other modifiers to announce changes during seeks, check how the system UI works), but sadly using the slider this way works but leads to a resource leak. It is likely an issue we should report to Apple. Otherwise our custom player UI is pretty much already accessible, thanks to the use of SF Symbols. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 14 days or if the stale label is not removed. |
This issue has been automatically closed because it has not had recent activity. |
The leaks can still be reproduced with iOS 17.6.1. |
The leak is not associated with the slider. We can reproduce it in the current demo as follows:
I will therefore submit the slider improvement as a separate PR and keep this branch open. The issue should probably be reported to Apple (it is still visible in iOS 18 beta 8). |
As a user requiring accessibility features I would like to be able to use the Pillarbox demo application with VoiceOver. As a developer integrating Pillarbox I would like to have a good example of how player accessibility can be implemented.
Acceptance criteria
Tasks
The text was updated successfully, but these errors were encountered: