New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

effect size should be d in the summary #31

Open

pbellec opened this issue Oct 16, 2023 · 0 comments

Member

pbellec commented Oct 16, 2023

This is displaying theta, from the old (obsolete) Bellec et al 2015 paper. You should directly show d, we don't care about theta (except maybe to compare your results with those of the old paper).
https://github.com/SIMEXP/ad_sz/blob/418f32358e78d7ec968aaa28e14a2a64d07f0afd/scripts/simulation_tools_v2.py#L197C51-L197C51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment