Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The baseline reproduction result is wrong #6

Open
lmllmllm opened this issue Jun 21, 2024 · 2 comments
Open

The baseline reproduction result is wrong #6

lmllmllm opened this issue Jun 21, 2024 · 2 comments

Comments

@lmllmllm
Copy link

OISST dataset:
DDPM test results for SST:
test/50ens_mems/avg/mse=1211.059
test/50ens_mems/avg/crps=24.399
test/50ens_mems/avg/ssr=2.479
The results of the two repeated experiments are almost the same
But for Dyffusion and MCVD, I can reproduce the results similar to those in the paper according to your code
I would like to ask how to reproduce the results of DDPM
Secondly, do you have the corresponding codes for the other two baselines Dropout and Perturbation in your project?
I am a beginner and hope to get your help.

@salvaRC
Copy link
Collaborator

salvaRC commented Jun 26, 2024

Hi and thanks for your comments!

To better understand why this is happening, could you share the config that you're using (i.e. the hydra_config.yaml file)?
I must say that I didn't re-run the DDPM baseline after cleaning up the code, so the default hyperparameters might not be optimal. For example, using fewer diffusion steps (e.g. diffusion.timesteps=5) was important for some datasets. Did you do this?

For the dropout baseline, use the <dataset>_time_conditioned.yaml configs in configs/experiment/.
For the perturbation baseline, simply train a deterministic model (module.enable_inference_dropout=False) and run inference/tests setting module.prediction_inputs_noise=EPS for EPS>0.

`

@lmllmllm
Copy link
Author

lmllmllm commented Jul 1, 2024

Thank you for your reply, this is my configuration
hydra_config-v2.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants