Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are failing on Contents.json output #225

Closed
hadiidbouk opened this issue Dec 4, 2023 · 11 comments · Fixed by #230 or #231
Closed

Tests are failing on Contents.json output #225

hadiidbouk opened this issue Dec 4, 2023 · 11 comments · Fixed by #230 or #231
Labels
bug Something isn't working

Comments

@hadiidbouk
Copy link

Hey

There are two failing tests:
testExport_preservesVectorRepresentation & testExport_preservesVectorRepresentation2

It seems it's related to the generated Contents.json file where the properties aren't sorted correctly.

image

@subdan
Copy link
Collaborator

subdan commented Dec 6, 2023

It's weird. The tests pass without any failures on CI and my Mac.

@subdan
Copy link
Collaborator

subdan commented Dec 6, 2023

Which version of Xcode are you using?

@subdan subdan added the question Further information is requested label Dec 31, 2023
@sanghoonkim1
Copy link

I meet same problem. I am using xcode 15.0. The order of properties changes every time I export.

@KulakovaE
Copy link

I meet same problem. I am using xcode 15.0. The order of properties changes every time I export.

Same here.

@subdan subdan added bug Something isn't working and removed question Further information is requested labels Jan 24, 2024
subdan added a commit that referenced this issue Jan 24, 2024
subdan added a commit that referenced this issue Jan 24, 2024
@subdan
Copy link
Collaborator

subdan commented Jan 24, 2024

Thanks for report. The issue has been fixed.

@mbruegmann
Copy link

Can you provide a new release including this fix?

@subdan
Copy link
Collaborator

subdan commented Feb 5, 2024

@mbruegmann
Copy link

@subdan Awesome, thank you!

subdan added a commit that referenced this issue Feb 9, 2024
subdan added a commit that referenced this issue Feb 9, 2024
@subdan
Copy link
Collaborator

subdan commented Feb 9, 2024

@mbruegmann, oops, sorry. GitHub says that the branch with the fix merged into master but it is not. I've fixed it and make a new release. Please check.

@mbruegmann
Copy link

Works perfectly now! 🚀 Thanks @subdan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants