-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: align style use between docs and demo #1862
Conversation
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size Change: 0 B Total Size: 183 kB ℹ️ View Unchanged
|
Im ok with global tokens style sheets in the demos, but nothing more Users should be able to copy demo contents onto a blank page and get results |
This changes nothing about that, this is more just house keeping on our end. The main thing this does if anything is just provides tokens to typography.css which was already loaded in playground. However when fallbacks were removed we lost the values: ie:
font-family and line-height were no longer available |
@bennypowers PTAL a look again, this last commit might have clarified stuff a bit more. |
Just realized this the part where i run into the dev-server trying to call global.css from the node_modules and gets wrapped in js... Update: was able to get around that issue by excluding that file in the litcssOptions in web-dev-server config. |
What I did
Testing Instructions
Notes to Reviewers