[ADDONS] Fatal error on multiple add-ons

[x3003]

I just unpacked the 3.1 package, started the launcher and selected all add-ons to test, but a few wouldn't start
I got these errors:

[Tormentor667]

Did you load the addons single-wise?

[x3003]

I loaded them from within the launcher.

[Tormentor667]

Single or multiple?

[mgrinzPlayer]

@x3003 some add-ons are not compatible with each other, e.g. grenades_only & movement

[x3003]

Multiple

[Tormentor667]

@x3003 some add-ons are not compatible with each other, e.g. grenades_only & movement

That was to be expected, we should have tried it before the release...

[mgrinzPlayer]

I tried it on 23 May:

Is "Grenades Only" compatible with "Movement". I tried
-file addons\movement.pk3 addons\grenades_only.pk3 only "Grenades Only" works
-file addons\grenades_only.pk3 addons\movement.pk3 only "Movement" works

I'm doing something wrong?

[Tormentor667]

I think some combinations works, others don't. Whats bad is that M2H doesn't work at all.

That has been fixed by me today, and have posted it on BoA-Addons discord channel as well in case people wants to have it fixed somehow --Ozy81

[x3003]

Yes, some combos works and others don't.

[Ozymandias81]

Well then I suggest to state that mods must be loaded only once, not together so we don't have to track which works or not, what do you think @Tormentor667 @Username-N00b-is-not-available @mgrinzPlayer ?

[x3003]

Well vampire & behaviour won't work. And melee & more weapons don't like each other either. And melee & behaviour.

[mgrinzPlayer]

Test every add-on combination (excluding simple add-ons like "8bitmusic", "lowres_models"):

Those pairs:

behaviour vs disable_hints 🟡
behaviour vs efficiency 🟡
behaviour vs grenades_only 🟡
behaviour vs instagib 🟡
behaviour vs m2hb 🟡
behaviour vs melee 🔴
behaviour vs more_weapons 🟡
behaviour vs movement 🟡
behaviour vs score 🟡
behaviour vs vampire 🔴

disable_hints vs efficiency 🟡
disable_hints vs grenades_only 🟢
disable_hints vs instagib 🟡
disable_hints vs m2hb 🟡
disable_hints vs melee 🟡
disable_hints vs more_weapons 🟡
disable_hints vs movement 🟡
disable_hints vs score 🟡
disable_hints vs vampire 🟡

efficiency vs grenades_only 🟡
efficiency vs instagib 🟡
efficiency vs m2hb 🟡
efficiency vs melee 🟡
efficiency vs more_weapons 🟡
efficiency vs movement 🟡
efficiency vs score 🟡
efficiency vs vampire 🟡

grenades_only vs instagib 🟡
grenades_only vs m2hb 🟡
grenades_only vs melee 🟡
grenades_only vs more_weapons 🟡
grenades_only vs movement 🔴
grenades_only vs score 🟡
grenades_only vs vampire 🟡

instagib vs m2hb 🟡
instagib vs melee 🟡
instagib vs more_weapons 🟡
instagib vs movement 🟡
instagib vs score 🟡
instagib vs vampire 🟡

m2hb vs melee 🟡
m2hb vs more_weapons 🟡
m2hb vs movement 🟡
m2hb vs score 🟡
m2hb vs vampire 🟡

melee vs more_weapons 🔴
melee vs movement 🟡
melee vs score 🟡
melee vs vampire 🟡

more_weapons vs movement 🟡
more_weapons vs score 🟡
more_weapons vs vampire 🟡

movement vs score 🟡
movement vs vampire 🟡

score vs vampire 🟡

Mark working add-on pairs with green 🟢, not working with red 🔴.
not tested 🟡. I marked few working and not working.

Then update addon.info with DOESNOTLIKE line based on above informations,

e.g. for behaviour it would be:
doesnotlike = melee.boa;vampire;....

Then I could block some add-ons combinations in "select multiple addons" window.

[Tormentor667]

This is a very good solution, we need to incorporate that!

[Ozymandias81]

And what about then when someone will come with new ones? I don't find it user friendly, best solution is to stitch with one addon per campaign.

[mgrinzPlayer]

Question:

From what I see inside boa-addons\source\movement\mapinfo.txt

gameinfo
{
	PlayerClasses = "MovementBoAPlayer"
	AddEventHandlers = "MovementHandler"
}

And inside boa-addons\source\grenades_only\mapinfo.txt

gameinfo
{
	PlayerClasses = "GrenadierBoAPlayer"
	AddEventHandlers = "GrenadierHandler"
}

They do not work with each other because there are two different player classes: MovementBoAPlayer and GrenadierBoAPlayer.
Can we detect "multiaddon incompatibility" by looking into mapinfo.txt, zscript.txt?
If yes, I can add few extra checks to be sure there are no more than one add-on with PlayerClasses inside mapinfo.txt in the "launch with" list.

I can add even more checks, if you can find some.

[Tormentor667]

I'd point @AFADoomer , @Username-N00b-is-not-available and @Talon1024 to this.

[Tormentor667]

Push'd

[mgrinzPlayer]

Nobody answered my question above or suggested other checks. I can add "add-on collision detection" based on information gathered from mapinfo.txt, zscript.txt.

i.e. if there is add-on with altered PlayerClasses (mapinfo.txt gameinfo section), you can not add any other add-on with with altered PlayerClasses.

[Tormentor667]

This sounds like a pretty good idea. The problem for me is, that I am not deep enough into the code of the addons and code in BoA in general to answer that question. I am sure @Username-N00b-is-not-available @AFADoomer @Talon1024 can help here more.

[Tormentor667]

As nothing is happening here, what about adding a note to the launcher @mgrinzPlayer that says "Combining various different addons might result in a crash, play at your own risk but feel free to report it at https://github.com/Realm667/WolfenDoom/issues" or something like that?

[Username-N00b-is-not-available]

I have transferred the addon-specific issues we currently have to the addon repository.