Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual indicator of volume change #155

Closed
RamonUnch opened this issue Jan 29, 2022 · 9 comments
Closed

Visual indicator of volume change #155

RamonUnch opened this issue Jan 29, 2022 · 9 comments
Labels
enhancement New feature or request WIP Work in progress

Comments

@RamonUnch
Copy link
Owner

As suggested by @cojoMan here, I modified the Volume wheel action to simply send the volume up/down keys, so it should show the volume indicator like whn using the multimedia keys.
Here are some test builds of AltSnap.

AltSnap1.50test1bin.zip
AltSnap1.50test1bin_x64.zip
AltSnap1.50test1-installers.zip

@cojoMan
Copy link

cojoMan commented Jan 29, 2022

Oh wooow, I didn't know about this fork, so many new options. Checking it out !

@cojoMan
Copy link

cojoMan commented Jan 29, 2022

works wonder, thank you, already switched, and checking out the other options !

@RamonUnch
Copy link
Owner Author

You might be interested in looking at the wiki for more details: https://github.com/RamonUnch/AltSnap/wiki

@RamonUnch RamonUnch added enhancement New feature or request WIP Work in progress labels Jan 30, 2022
@Ichisich
Copy link

Ichisich commented Feb 1, 2022

@RamonUnch
Great addition.
But wheel input still doesn't get recognized on the desktop as long as the mouse cursor isn't in a window or the taskbar.
This is not a regression, and was, to my knowledge, always the case with altdrag/snap.

I guess you're using the SystemMediaTransportControls API to show the overlay?
If so, you could also add the instructions:
Volume_Mute
Media_Play_Pause
Media_Prev
Media_Next

@RamonUnch
Copy link
Owner Author

But wheel input still doesn't get recognized on the desktop as long as the mouse cursor isn't in a window or the taskbar.
This is not a regression, and was, to my knowledge, always the case with altdrag/snap.

The desktop is in the scroll blacklist. Just clear this blacklist if it if you want to be able to adjust volume everywhere.
I do not want to have a separated blacklist for every action...

I actually just send the multimedia vkeys to the system and Windows shows himself the appropriate volume control. Multimedia keys are:

vKey HEX Description
VK_VOLUME_MUTE 0xAD Volume Mute key
VK_VOLUME_DOWN 0xAE Volume Down key
VK_VOLUME_UP 0xAF Volume Up key
VK_MEDIA_NEXT_TRACK 0xB0 Next Track key
VK_MEDIA_PREV_TRACK 0xB1 Previous Track key
VK_MEDIA_STOP 0xB2 Stop Media key
VK_MEDIA_PLAY_PAUSE 0xB3 Play/Pause Media key

How do you think the other keys could be used?
New actions for each key?

@Ichisich
Copy link

Ichisich commented Feb 1, 2022

The desktop is in the scroll blacklist.

Sorry, I just looked at the process blacklist.

I actually just send the multimedia vkeys to the system and Windows shows himself the appropriate volume control.

Neat, so it works with Windows prior to 8/10 as well.

How do you think the other keys could be used? New actions for each key?

For Mute and Pause/Play, yes.
Next/Prev could be mapped to the wheel, same as Volume, and Stop is somewhat superfluous with Pause/Play existing.

@RamonUnch
Copy link
Owner Author

For Mute and Pause/Play, yes.
Next/Prev could be mapped to the wheel, same as Volume, and Stop is somewhat superfluous with Pause/Play existing.

After some testing, it seems that those keys have to be sent to the playing application. So to use them you would need to focus the media player, this would make those Play/Pause/Stop and Next/Prev actions a bit "useless" to me. When thinking about it it is obvious, for a program to handle those key without focus, they would need a low level keyboard hook.

Mute is handled by the system (like the volume) so it works as intended. I will add this one for sure.

@cojoMan
Copy link

cojoMan commented Feb 1, 2022

The desktop is in the scroll blacklist. Just clear this blacklist if it if you want to be able to adjust volume everywhere. I do not

For the uninitiated, what is the process I have to remove from the blacklist to have the volume act on desktop hovering as well ?
Currently the windows blacklist looks like this :

Program Manager|Progman,|MultitaskingViewFrame,Volume Control|Tray Volume,Volume Control|Windows.UI.Core.CoreWindow,|TaskSwitcherWnd,|TaskSwitcherOverlayWnd,|WorkerW,|Shell_TrayWnd,|BaseBar,|#32768,|XamlExplorerHostIslandWindow,*|TSSHELLWND

@Ichisich
Copy link

Ichisich commented Feb 1, 2022

https://github.com/RamonUnch/AltSnap/wiki#blacklists

Unbenannt

You can either delete the marked entry or just comment it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request WIP Work in progress
Projects
None yet
Development

No branches or pull requests

3 participants