From 433b13bc3dccb497452f952ba80b2ceca48d723c Mon Sep 17 00:00:00 2001 From: Ramakrishna Chilaka Date: Thu, 18 Apr 2024 12:20:15 +0530 Subject: [PATCH] setting ActiveOption to undefined on first load --- public/pages/Main/Main.tsx | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/public/pages/Main/Main.tsx b/public/pages/Main/Main.tsx index 7548c7680..6f48fb144 100644 --- a/public/pages/Main/Main.tsx +++ b/public/pages/Main/Main.tsx @@ -66,7 +66,6 @@ import { DataSourceViewConfig, } from "../../../../../src/plugins/data_source_management/public"; import { DataSourceOption } from "../../../../../src/plugins/data_source_management/public/components/data_source_menu/types"; -import { ImageType } from "../../../../../src/core/common"; enum Navigation { IndexManagement = "Index Management", @@ -245,7 +244,7 @@ export default class Main extends Component { onSelectedDataSources = (dataSources: DataSourceOption[]) => { const { id = "", label = "" } = dataSources[0] || {}; - if (this.state.dataSourceId != id || this.state.dataSourceLabel != label) { + if (this.state.dataSourceId !== id || this.state.dataSourceLabel !== label) { this.setState({ dataSourceId: id, dataSourceLabel: label, @@ -365,6 +364,14 @@ export default class Main extends Component { const DataSourceMenu = this.props.dataSourceManagement?.ui?.getDataSourceMenu(); const DataSourceViewer = this.props.dataSourceManagement?.ui?.getDataSourceMenu(); + const activeOption: DataSourceOption[] | undefined = this.state.dataSourceLoading + ? undefined + : [ + { + label: this.state.dataSourceLabel, + id: this.state.dataSourceId, + }, + ]; return ( @@ -405,7 +412,7 @@ export default class Main extends Component { setMenuMountPoint={this.props.setActionMenu} componentType={"DataSourceView"} componentConfig={{ - activeOption: [{ label: this.state.dataSourceLabel, id: this.state.dataSourceId }], + activeOption, fullWidth: false, }} /> @@ -438,7 +445,7 @@ export default class Main extends Component { savedObjects: core?.savedObjects.client, notifications: core?.notifications, fullWidth: false, - activeOption: [{ label: this.state.dataSourceLabel, id: this.state.dataSourceId }], + activeOption, onSelectedDataSources: this.onSelectedDataSources, }} /> @@ -452,7 +459,7 @@ export default class Main extends Component { setMenuMountPoint={this.props.setActionMenu} componentType={"DataSourceView"} componentConfig={{ - activeOption: [{ label: this.state.dataSourceLabel, id: this.state.dataSourceId }], + activeOption, fullWidth: false, }} /> @@ -464,7 +471,7 @@ export default class Main extends Component { savedObjects: core?.savedObjects.client, notifications: core?.notifications, fullWidth: false, - activeOption: [{ label: this.state.dataSourceLabel, id: this.state.dataSourceId }], + activeOption, onSelectedDataSources: this.onSelectedDataSources, }} />