Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add Roctracer Timestamp Callback Call #102

Open
sraikund16 opened this issue Aug 22, 2024 · 2 comments
Open

[Feature]: Add Roctracer Timestamp Callback Call #102

sraikund16 opened this issue Aug 22, 2024 · 2 comments

Comments

@sraikund16
Copy link

Suggestion Description

When looking at the Timestamp Operations in roctracer.h, I noticed there is no way to change the clock that roctracer uses to set timestamps. This forces the user to use a system clock, which is not guaranteed to be monotonic. It would be useful to have a rocm version of cuptiActivityRegisterTimestampCallback so that we can set the timestamps to be monotonic.

Thank you.

Operating System

CentOS Stream 9

GPU

N/A

ROCm Component

roctracer

@pruthvistony
Copy link

@mwootton

@jrmadsen
Copy link

jrmadsen commented Sep 5, 2024

There are inherent underlying problems here which block this for being easily implemented. Roctracer/rocprofiler-sdk do not have control over the clock for GPU timestamps and those timestamps are given to us asynchronously. Thus, your callback cannot be invoked when the timestamp is recorded. It may be possible but it will likely require changes in the driver.

Side note, internally within the profiling tool libraries, we use CLOCK_BOOTTIME which is monotonic and generally aligns with the GPU timestamps (occasionally, we’ve detected skews which requires small shifts)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants