Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread Pool #8

Open
mav8557 opened this issue Jan 29, 2022 · 1 comment
Open

Thread Pool #8

mav8557 opened this issue Jan 29, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@mav8557
Copy link
Member

mav8557 commented Jan 29, 2022

Right now three goroutines are spawned per user, per box. This is a lot and will get slow with a large network.

A thread pool architecture can help. A certain number of threads, passed as configuration, are spawned at the beginning, and pull Jobs from the same channel. Each Job represents a connection attempt against a particular box, including the Username, IP, and protocol (SSH, SMB, winrm, etc).

@d3adzo d3adzo added the enhancement New feature or request label Jan 30, 2022
@mav8557
Copy link
Member Author

mav8557 commented Feb 15, 2023

Following up a year later while cleaning this up - an Async implementation would probably work for this also, and likely better. It's a good first tool facelift project, implementing both of these and testing to see which is truly fastest in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants