Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Submission]: Optimal Pauli string grouping for dense operators #488

Closed
atlytle opened this issue Aug 10, 2023 · 15 comments · Fixed by #489
Closed

[Submission]: Optimal Pauli string grouping for dense operators #488

atlytle opened this issue Aug 10, 2023 · 15 comments · Fixed by #489
Labels
ready submission Project submission

Comments

@atlytle
Copy link
Contributor

atlytle commented Aug 10, 2023

Github repo

https://github.com/atlytle/dense-ev

Description

Implements expectation value measurements in Qiskit using optimal dense grouping. Dense-ev provides an improvement of ~2^m over naive grouping and (3/2)^m over qubit-wise commuting groups. Based on arXiv:2305.11847.

Email

[email protected]

Alternatives

No response

License

Apache License 2.0

Affiliations

University of Illinois at Urbana-Champaign

Tags

paper implementation

Website

https://github.com/atlytle/dense-ev

@github-actions
Copy link
Contributor

Successfull submission! ✨ PR #489

@github-actions
Copy link
Contributor

Tests with latest version of Qiskit release passed! ✨

@github-actions
Copy link
Contributor

Tests with development version of Qiskit release passed! ✨

@mickahell mickahell added submission Project submission ready labels Aug 12, 2023
@mickahell
Copy link
Collaborator

Awesome 🚀

@mickahell mickahell assigned mickahell and unassigned mickahell Aug 12, 2023
@github-actions
Copy link
Contributor

Submission PR #489 has been created with errors in tests ⚠️
See logs: https://github.com/qiskit-community/ecosystem/actions/runs/5879934926
Please follow minimal requirements for project or/and add ecosystem.json configuration in the root of the project
Read more here https://github.com/qiskit-community/ecosystem/blob/main/docs/project_overview.md#adding-project-to-the-ecosystem

@github-actions
Copy link
Contributor

Tests with latest version of Qiskit release failed! ⚠️
This means your project doesn't work with the latest version of Qiskit.
This is purely informational and doesn't affect your project joining the Ecosystem, but you may want to investigate the problem.
See logs: https://github.com/qiskit-community/ecosystem/actions/runs/5879934926

@github-actions
Copy link
Contributor

Tests with development version of Qiskit release failed! ⚠️
This means your project might not work with the next version of Qiskit.
This is purely informational and doesn't affect your project joining Ecosystem.
See logs: https://github.com/qiskit-community/ecosystem/actions/runs/5879934926

@mickahell
Copy link
Collaborator

mickahell commented Aug 16, 2023

@atlytle seems your last commit make the tests doesn"t pass anymore :/

error :

2023-08-16 14:21:15 ecosystem INFO file /home/runner/work/ecosystem/ecosystem/ecosystem/resources/cloned_repo_directory/dense-ev/src/dense_ev/rmatrix.py, line 70
2023-08-16 14:21:15 ecosystem INFO def test_random_H(m):
2023-08-16 14:21:15 ecosystem INFO E       fixture 'm' not found
2023-08-16 14:21:15 ecosystem INFO >       available fixtures: cache, capfd, capfdbinary, caplog, capsys, capsysbinary, doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory

@atlytle
Copy link
Contributor Author

atlytle commented Aug 16, 2023

I had expanded the test coverage slightly, locally it runs ok with tox and unittest. I changed the function name to check_random_H(m) in case there is something automatic with functions "test*()". Do you have any suggestions? Thanks!

@mickahell
Copy link
Collaborator

mickahell commented Aug 16, 2023

@atlytle never mind
I just did a test run, and it seems to passed --> run log : https://github.com/mickahell/ecosystem/actions/runs/5882471443/job/15953060710
Maybe that was just a network problem or something like.

Can you just do an edit in your issue and modify a space or a dot and save, that'll launch the wf again :)

So still awesome your project passed first time 🚀

@github-actions
Copy link
Contributor

Successfull submission! ✨ PR #489

@github-actions
Copy link
Contributor

Tests with latest version of Qiskit release passed! ✨

@github-actions
Copy link
Contributor

Tests with development version of Qiskit release passed! ✨

frankharkins pushed a commit that referenced this issue Aug 17, 2023
Add dense-ev to list.
Closes #488

Co-authored-by: atlytle <[email protected]>
@1ucian0
Copy link
Member

1ucian0 commented Sep 6, 2023

hello @atlytle! You joined the Qiskit Ecosystem a little while ago and I just wanted to check in and let you know of some follow up actions you can take to make the most of joining the program, if you're interested:

💬 Join other Qiskit ecosystem developers in the Slack channel #qiskit-ecosystem (if you are not in the Qiskit workspace yet, you can sign up here: https://qisk.it/join-slack)

🧠 Help us define the future of the Qiskit Ecosystem: we recently started an RFC on how the Ecosystem should be structured. It is very draft-y at the moment, but you can subscribe for notifications here Qiskit/RFCs#46 to participate in that discussion.

📣 Would you like to showcase your project to the Qiskit community? A couple of things you can do to raise awareness for your project:

Great having you as a part of the ecosystem!

@atlytle
Copy link
Contributor Author

atlytle commented Sep 7, 2023

Thank you, @1ucian0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready submission Project submission
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants