-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does not cascade translation #10
Comments
The %-operator itself does work: that returns a new TranslationString instance with an updated mapping. The underlying issue is better described in #14: interpolate() does not check for TranslationString instances when inserting values. There are a three possible ways of fixing that:
The first option is cumbersome, but works today. The second option is impossible to implement: the interpolate method does not have access to the translation catalogs/policy, so it can't do the translation. The last option should be doable. |
Thanks for the feedback, do you plan to do that or are you waiting for pull requests on this as you don't have time? |
I'm planning to do it, but considering current priorities and available time it might be a while before I get to it. |
I've noticed that if I interpolate translated strings into translated strings - it doesn't work.
This happens something like this:
This makes it really hard to use this in places where you do not controll what strings get spliced into a translated strings - which is really unfortunate.
To my understanding, interpolate() needs to check all strings it interpolates and call interpolate on them too as needed.
The text was updated successfully, but these errors were encountered: