Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify doble mock in helper tests #362

Open
facundobatista opened this issue Mar 13, 2019 · 4 comments
Open

Simplify doble mock in helper tests #362

facundobatista opened this issue Mar 13, 2019 · 4 comments
Labels
Easy/Simple

Comments

@facundobatista
Copy link
Member

There are several tests in test_helpers.py that uses a double mock to mimick hitting the web to download scripts.

It's kind of cumbersome, it could be simplified to a self._mock_urlopen helper or something
@SreeCharan1234
Copy link

ok i want to contribute in it

@SreeCharan1234
Copy link

SreeCharan1234 commented Jun 27, 2024 •
edited
Loading

@facundobatista i have clone the this reposetry and studied the topic of Urllib module can i start working on it
image

@facundobatista
Copy link
Member Author

Sure, go for it!

@facundobatista
Copy link
Member Author

Note that tools evolved; probably there is a better way that was suggested in the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy/Simple
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@facundobatista @SreeCharan1234