Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an actuator model #7

Open
eldond opened this issue Sep 7, 2023 · 2 comments
Open

Make an actuator model #7

eldond opened this issue Sep 7, 2023 · 2 comments
Assignees

Comments

@eldond
Copy link
Collaborator

eldond commented Sep 7, 2023

  • We no longer anticipate getting a detailed actuator (gas puff) model from CFS
  • We should make our own gas valve model.
    • The designer of the CFS gas valves is Chris Chrobak, who was in charge of the DIII-D gas system. So, we can try to guess what he would design. It's been hinted that using DIII-D valves as a model will be an adequate approximation.
      • DIII-D valves are described by [Bates 1984] and [Burrell 1978]. DIII-D valves work very well and the KSTAR valves are based on the DIII-D design [Kim 2013]
      • The responsible officer for the DIII-D gas system is Igor Bykov
    • There may be some pipe between the piezoelectric crystal and the inlet to the vacuum vessel.
      • DIII-D valves GASD, PFX1, PFX2, LOB1, LOB2, etc. are examples of this setup. DIII-D valves GASA, GASB, GASC, and GASE do not have significant tubing between the valve assembly and the vessel and thus produce faster responses.
      • See GA internal Engineering Physics Memo EPMde20171218gas_dribble for information about performance of DIII-D valves with extra tubing included.
  • We need a transfer function between command voltage output by the PCS and gas flow rate.
    • Should be species-dependent
    • Should be sensitive to tubing length and number of bends in the pipe between valve and VV
    • Should have similar call structure to result of Make a simple actuator model for use in testing #6, or that development should be updated as needed so that APIs are similar or consistent
@eldond eldond changed the title Make an interface to an actuator model supplied by CFS Make an actuator model Nov 8, 2023
@eldond
Copy link
Collaborator Author

eldond commented Nov 8, 2023

Completion by the end of 2024 January is desired.

@anchal-physics anchal-physics self-assigned this Nov 8, 2023
@anchal-physics
Copy link
Collaborator

This has been partially addressed in ProjectTorreyPines/FusionSyntheticDiagnostics.jl#25

More features as requested will be added later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants