From 0e40a9b6a2f9e5f73ed87c6954b42ec11eb1c3a7 Mon Sep 17 00:00:00 2001 From: cterech Date: Thu, 11 Jan 2024 12:47:12 -0500 Subject: [PATCH] update readme to add address to args in verify command --- README.md | 27 +++------------------------ 1 file changed, 3 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index 3f63ce5..cc0ead5 100644 --- a/README.md +++ b/README.md @@ -69,8 +69,8 @@ Verify the contract on Etherscan: ```bash forge verify-contract Dockmaster --watch \ - --constructor-args $(cast abi-encode "constructor(string,string)" \ - "Dockmaster NFT" "DM") --chain 5 + --constructor-args $(cast abi-encode "constructor(string,string,address)" \ + "Dockmaster NFT" "DM" "0x0000000000000000000000000000000000000000") --chain 5 ``` Running this command merely deploys the unchanged example NFT contract to a testnet, but it's a good way to check for a properly functioning dev environment. @@ -95,25 +95,4 @@ brew install lcov To generate reports, run ```bash ./coverage-report -``` - - - -## Roadmap - -- [x] Configure test.yml to run `forge test` on every push to main and PR -- [x] Add a `forge fmt --check` workflow to the Github Actions -- [x] Add an optional `forge fmt` fix workflow to the Github Actions -- [ ] Include base dependencies - - [x] OZ - - [ ] Pin to version - - [x] Solady - - [ ] Pin to version - - [x] Shipyard-core - - [ ] Pin to version -- [x] Include a base cross-chain deploy script -- [ ] Figure out if there's a way we can make `forge verify-contract` more ergonomic -- [ ] Top-level helpers: - - [x] PRB's `reinit-submodules` script as top-level helper - - [x] `coverage-report` script as top-level helper - - [ ] TODO: are there security concerns about these? \ No newline at end of file +``` \ No newline at end of file