Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let DataFrame automatically download the CSV #130

Open
hernanmd opened this issue May 22, 2020 · 5 comments
Open

Let DataFrame automatically download the CSV #130

hernanmd opened this issue May 22, 2020 · 5 comments

Comments

@hernanmd
Copy link
Collaborator

Currently DataFrame only expects a FileReference as parameter to create an instance:

DataFrame readFromCsv: '/dir1/dir2/myfile.csv' asFileReference

It could be a nice time saver to let the DataFrame actually "resolve" the parameter and download a CSV in a URL String transparently, for example:

DataFrame readFromCsv: 'http://path/to/url/myfile.csv'
@Ducasse
Copy link

Ducasse commented May 22, 2020

I would prefer to have another method because else it means suddenly data frame is linked with Zinc.
Having a stream based API however could be nice to have

DataFrame readFromCsvOn: asStream

@olekscode
Copy link
Member

We can have something like this:

DataFrame >> readFromCsv: aFileReference.
DataFrame >> readFromCsvByUrl: aString.

df readFromCsv: '/dir1/dir2/myfile.csv' asFileReference.
df readFromCsvByUrl: 'http://path/to/url/myfile.csv'.

@olekscode olekscode added the api label Jul 26, 2021
@olekscode olekscode added this to the v3.0 milestone Jul 26, 2021
@hernanmd
Copy link
Collaborator Author

Cool, thanks!

@jecisc
Copy link
Member

jecisc commented Feb 15, 2023

I don’t think this is yet implemented. Should this really be closed?

@hernanmd
Copy link
Collaborator Author

You're right, I misread it "readFromCsvByUrl" and thought it was already implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants