Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sprite for Galarian Moltres is the one for Galarion Zigzagoon #688

Closed
thibaudbrault opened this issue Feb 11, 2022 · 12 comments
Closed

Sprite for Galarian Moltres is the one for Galarion Zigzagoon #688

thibaudbrault opened this issue Feb 11, 2022 · 12 comments

Comments

@thibaudbrault
Copy link

What is said in the title the sprites for galarian moltres are the ones for galarian zigzagoon

@Naramsim
Copy link
Member

Ugh, thanks for the info.

Would you be able to propose a fix?

@thibaudbrault
Copy link
Author

I would gladly help but I don't know how to fix that and I don't know Python.

@Naramsim
Copy link
Member

Naramsim commented Feb 11, 2022

Argh!!!!

All the galar varieties mismatch!

We have a problem. I think I'll revert to a previous version. Let's keep analyzing using the staging version.

https://staging.pokeapi.co/api/v2/pokemon/10170/
https://pokeapi.co/api/v2/pokemon/10170/

@Naramsim
Copy link
Member

So last PR (PokeAPI/pokedex#86) messed up some IDs, I think the ones above 10000. But I didn't fully analyze the issue

@thibaudbrault
Copy link
Author

Ok
What did it do ?

@C-Garza
Copy link
Member

C-Garza commented Feb 11, 2022

Right, we shifted the galarian id's but we didn't rename the sprite images since it's tied with their id.

In the pokemon.csv, everything above 10158 got renamed, and in the pokemon_forms.csv, everything above 10317 got renamed.

@thibaudbrault
Copy link
Author

So in pokemon_forms.csv everything between 10158 and 10317 needs to be renamed ?

@C-Garza
Copy link
Member

C-Garza commented Feb 11, 2022

Yeah, this should be a one time thing since we're syncing up with veekun. I'll try to rename the existing sprites to the new id's with a script and make a PR.

@thibaudbrault
Copy link
Author

Ok
Great
Thx for the answers

@Naramsim
Copy link
Member

Ok, it seems to work, can you confirm @thibaudbrault ?

huge thanks to @C-Garza

@thibaudbrault
Copy link
Author

Right now I can't but I'll look tomorrow

@thibaudbrault
Copy link
Author

I just checked an it works; Thx for fixing it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants