Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve root finding accuracy on low res grids #1200

Closed
unalmis opened this issue Aug 16, 2024 · 0 comments · Fixed by #1199
Closed

Improve root finding accuracy on low res grids #1200

unalmis opened this issue Aug 16, 2024 · 0 comments · Fixed by #1199
Assignees

Comments

@unalmis
Copy link
Collaborator

unalmis commented Aug 16, 2024

After reducing resolution of Quadrature grid in draft pull request, the map_coordinates test is failing because this decreases the number of radial knots used to construct a cubic spline of iota, which deteriorates the 3d root finding used by default in map_coordinates.

Given that iota is the main ingredient in all these coordinate mappings, the solution is to update map_coordinates to also compute iota_r and feed that into interpax.interp1d with the undocumented kwarg fx=iota_r to compute Hermite spline.

Originally posted by @unalmis in #1188 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant