You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Previously, the following USD would render blue in Storm and red in RenderMan (as-expected). With USDIMAGINGGL_ENGINE_ENABLE_SCENE_INDEX=1 it renders blue in both cases.
I see there's a HdMaterialBindingsSchema::GetMaterialBinding(TfToken const &purpose) function, but it doesn't look like anything actually calls this. HdSceneIndexAdapterSceneDelegate::GetMaterialId() goes through the default (i.e., no explicit purpose).
It's easy enough to change HdSceneIndexAdapterSceneDelegate to leverage GetRenderIndex().GetRenderDelegate()->GetMaterialBindingPurpose() and call HdMaterialBindingsSchema::GetMaterialBinding(TfToken const &purpose), which makes the reported test case pass, but I worry this is insufficient as there seem to be other calls to HdMaterialBindingsSchema::GetMaterialBinding() (i.e., the purpose-less version) scattered throughout the codebase. And by "insufficient", that might actually be "best-case" and it is possibly even worse if there is inconsistency where different codepaths are generating different material bindings.
…red) material binding.
Note there still remain calls to the generic GetMaterialBinding() in:
* collectionPredicateLibrary - hd
* materialPrimvarTransferSceneIndex - hdSi
* dependencySceneIndexPlugin - hdSt
* retesselationSceneIndexPlugin - hdPrman
This is to address issue PixarAnimationStudios#3320 (with the above unsolved bits mentioned above)
Previously, the following USD would render blue in Storm and red in RenderMan (as-expected). With
USDIMAGINGGL_ENGINE_ENABLE_SCENE_INDEX=1
it renders blue in both cases.I see there's a
HdMaterialBindingsSchema::GetMaterialBinding(TfToken const &purpose)
function, but it doesn't look like anything actually calls this.HdSceneIndexAdapterSceneDelegate::GetMaterialId()
goes through the default (i.e., no explicit purpose).The text was updated successfully, but these errors were encountered: