From e53076573740239f91357bbb9320dbf8a80082f1 Mon Sep 17 00:00:00 2001 From: Dariusz Zbyrad Date: Wed, 16 Oct 2024 11:10:00 +0200 Subject: [PATCH] Add checkstyle plugin --- config/checkstyle/checkstyle.xml | 12 ++++++++++++ .../com/pi4j/library/pigpio/PiGpio_Servo.java | 2 -- .../impl/DigitalConfigBuilderBase.java | 1 - .../platform/ManualPlatformsCtorTest.java | 1 - .../GpioDDigitalInputProviderImpl.java | 1 - .../GpioDDigitalOutputProviderImpl.java | 1 - .../provider/i2c/LinuxFsI2CProviderImpl.java | 1 - .../analog/MockAnalogInputProviderImpl.java | 1 - .../analog/MockAnalogOutputProviderImpl.java | 1 - .../digital/MockDigitalInputProviderImpl.java | 1 - .../MockDigitalOutputProviderImpl.java | 1 - .../provider/i2c/MockI2CProviderImpl.java | 1 - .../provider/pwm/MockPwmProviderImpl.java | 1 - .../serial/MockSerialProviderImpl.java | 1 - .../provider/spi/MockSpiProviderImpl.java | 1 - .../pigpio/provider/serial/PiGpioSerial.java | 2 -- .../digital/RpiDigitalInputProviderImpl.java | 1 - .../digital/RpiDigitalOutputProviderImpl.java | 1 - .../provider/i2c/RpiI2CProviderImpl.java | 1 - .../provider/pwm/RpiPwmProviderImpl.java | 1 - .../serial/RpiSerialProviderImpl.java | 1 - .../provider/spi/RpiSpiProviderImpl.java | 1 - pom.xml | 19 +++++++++++++++++++ 23 files changed, 31 insertions(+), 23 deletions(-) create mode 100644 config/checkstyle/checkstyle.xml diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml new file mode 100644 index 00000000..fd77b1a3 --- /dev/null +++ b/config/checkstyle/checkstyle.xml @@ -0,0 +1,12 @@ + + + + + + + + + + \ No newline at end of file diff --git a/libraries/pi4j-library-pigpio/src/main/java/com/pi4j/library/pigpio/PiGpio_Servo.java b/libraries/pi4j-library-pigpio/src/main/java/com/pi4j/library/pigpio/PiGpio_Servo.java index 810f2304..e4280499 100644 --- a/libraries/pi4j-library-pigpio/src/main/java/com/pi4j/library/pigpio/PiGpio_Servo.java +++ b/libraries/pi4j-library-pigpio/src/main/java/com/pi4j/library/pigpio/PiGpio_Servo.java @@ -27,8 +27,6 @@ * #L% */ -import java.io.IOException; - /** *

PiGpio_Servo interface.

* diff --git a/pi4j-core/src/main/java/com/pi4j/io/gpio/digital/impl/DigitalConfigBuilderBase.java b/pi4j-core/src/main/java/com/pi4j/io/gpio/digital/impl/DigitalConfigBuilderBase.java index c9d591d6..e5d8e90f 100644 --- a/pi4j-core/src/main/java/com/pi4j/io/gpio/digital/impl/DigitalConfigBuilderBase.java +++ b/pi4j-core/src/main/java/com/pi4j/io/gpio/digital/impl/DigitalConfigBuilderBase.java @@ -28,7 +28,6 @@ import com.pi4j.context.Context; import com.pi4j.io.gpio.digital.DigitalConfig; import com.pi4j.io.gpio.digital.DigitalConfigBuilder; -import com.pi4j.io.gpio.digital.DigitalOutputConfigBuilder; import com.pi4j.io.gpio.digital.DigitalState; import com.pi4j.io.impl.IOAddressConfigBuilderBase; diff --git a/pi4j-test/src/test/java/com/pi4j/test/platform/ManualPlatformsCtorTest.java b/pi4j-test/src/test/java/com/pi4j/test/platform/ManualPlatformsCtorTest.java index 816059b2..9484048c 100644 --- a/pi4j-test/src/test/java/com/pi4j/test/platform/ManualPlatformsCtorTest.java +++ b/pi4j-test/src/test/java/com/pi4j/test/platform/ManualPlatformsCtorTest.java @@ -30,7 +30,6 @@ import com.pi4j.Pi4J; import com.pi4j.context.Context; -import com.pi4j.exception.Pi4JException; import com.pi4j.test.provider.TestI2CProvider; import com.pi4j.test.provider.TestPwmProvider; import com.pi4j.test.provider.TestSerialProvider; diff --git a/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalInputProviderImpl.java b/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalInputProviderImpl.java index 4ea0c651..584d5e0c 100644 --- a/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalInputProviderImpl.java +++ b/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalInputProviderImpl.java @@ -1,7 +1,6 @@ package com.pi4j.plugin.gpiod.provider.gpio.digital; -import com.pi4j.boardinfo.util.BoardInfoHelper; import com.pi4j.context.Context; import com.pi4j.exception.InitializeException; import com.pi4j.exception.ShutdownException; diff --git a/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalOutputProviderImpl.java b/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalOutputProviderImpl.java index 58078976..f05335ec 100644 --- a/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalOutputProviderImpl.java +++ b/plugins/pi4j-plugin-gpiod/src/main/java/com/pi4j/plugin/gpiod/provider/gpio/digital/GpioDDigitalOutputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.boardinfo.util.BoardInfoHelper; import com.pi4j.context.Context; import com.pi4j.exception.InitializeException; import com.pi4j.exception.ShutdownException; diff --git a/plugins/pi4j-plugin-linuxfs/src/main/java/com/pi4j/plugin/linuxfs/provider/i2c/LinuxFsI2CProviderImpl.java b/plugins/pi4j-plugin-linuxfs/src/main/java/com/pi4j/plugin/linuxfs/provider/i2c/LinuxFsI2CProviderImpl.java index 210c74e5..5ff211e8 100644 --- a/plugins/pi4j-plugin-linuxfs/src/main/java/com/pi4j/plugin/linuxfs/provider/i2c/LinuxFsI2CProviderImpl.java +++ b/plugins/pi4j-plugin-linuxfs/src/main/java/com/pi4j/plugin/linuxfs/provider/i2c/LinuxFsI2CProviderImpl.java @@ -28,7 +28,6 @@ */ -import com.pi4j.boardinfo.util.BoardInfoHelper; import com.pi4j.context.Context; import com.pi4j.exception.ShutdownException; import com.pi4j.io.i2c.I2C; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogInputProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogInputProviderImpl.java index a022ec4c..4ff2857b 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogInputProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogInputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.analog.AnalogInput; import com.pi4j.io.gpio.analog.AnalogInputConfig; import com.pi4j.io.gpio.analog.AnalogInputProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogOutputProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogOutputProviderImpl.java index b860581b..bfe9f59c 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogOutputProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/analog/MockAnalogOutputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.analog.AnalogOutput; import com.pi4j.io.gpio.analog.AnalogOutputConfig; import com.pi4j.io.gpio.analog.AnalogOutputProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalInputProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalInputProviderImpl.java index 95f78ad9..5a6a4669 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalInputProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalInputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.digital.DigitalInput; import com.pi4j.io.gpio.digital.DigitalInputConfig; import com.pi4j.io.gpio.digital.DigitalInputProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalOutputProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalOutputProviderImpl.java index 8079c4a4..4a310518 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalOutputProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/gpio/digital/MockDigitalOutputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.digital.DigitalOutput; import com.pi4j.io.gpio.digital.DigitalOutputConfig; import com.pi4j.io.gpio.digital.DigitalOutputProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/i2c/MockI2CProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/i2c/MockI2CProviderImpl.java index c300f726..761d93b2 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/i2c/MockI2CProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/i2c/MockI2CProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.i2c.I2C; import com.pi4j.io.i2c.I2CConfig; import com.pi4j.io.i2c.I2CProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/pwm/MockPwmProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/pwm/MockPwmProviderImpl.java index a92bcce7..7253eccf 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/pwm/MockPwmProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/pwm/MockPwmProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.pwm.Pwm; import com.pi4j.io.pwm.PwmConfig; import com.pi4j.io.pwm.PwmProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/serial/MockSerialProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/serial/MockSerialProviderImpl.java index b6a750e1..926cb54f 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/serial/MockSerialProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/serial/MockSerialProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.serial.Serial; import com.pi4j.io.serial.SerialConfig; import com.pi4j.io.serial.SerialProviderBase; diff --git a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/spi/MockSpiProviderImpl.java b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/spi/MockSpiProviderImpl.java index b848f3a8..6e24fb73 100644 --- a/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/spi/MockSpiProviderImpl.java +++ b/plugins/pi4j-plugin-mock/src/main/java/com/pi4j/plugin/mock/provider/spi/MockSpiProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.spi.Spi; import com.pi4j.io.spi.SpiConfig; import com.pi4j.io.spi.SpiProviderBase; diff --git a/plugins/pi4j-plugin-pigpio/src/main/java/com/pi4j/plugin/pigpio/provider/serial/PiGpioSerial.java b/plugins/pi4j-plugin-pigpio/src/main/java/com/pi4j/plugin/pigpio/provider/serial/PiGpioSerial.java index db846a85..db58370c 100644 --- a/plugins/pi4j-plugin-pigpio/src/main/java/com/pi4j/plugin/pigpio/provider/serial/PiGpioSerial.java +++ b/plugins/pi4j-plugin-pigpio/src/main/java/com/pi4j/plugin/pigpio/provider/serial/PiGpioSerial.java @@ -37,8 +37,6 @@ import com.pi4j.library.pigpio.PiGpio; import com.pi4j.library.pigpio.PiGpioMode; -import java.io.IOException; - /** *

PiGpioSerial class.

* diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalInputProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalInputProviderImpl.java index b249c518..61eb3da6 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalInputProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalInputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.digital.DigitalInput; import com.pi4j.io.gpio.digital.DigitalInputConfig; import com.pi4j.io.gpio.digital.DigitalInputProviderBase; diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalOutputProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalOutputProviderImpl.java index aba25f38..7df669e7 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalOutputProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/gpio/digital/RpiDigitalOutputProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.gpio.digital.DigitalOutput; import com.pi4j.io.gpio.digital.DigitalOutputConfig; import com.pi4j.io.gpio.digital.DigitalOutputProviderBase; diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/i2c/RpiI2CProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/i2c/RpiI2CProviderImpl.java index a91980d1..21159d2b 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/i2c/RpiI2CProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/i2c/RpiI2CProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.i2c.I2C; import com.pi4j.io.i2c.I2CConfig; import com.pi4j.io.i2c.I2CProviderBase; diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/pwm/RpiPwmProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/pwm/RpiPwmProviderImpl.java index a70ba424..e1bd7ef6 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/pwm/RpiPwmProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/pwm/RpiPwmProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.pwm.Pwm; import com.pi4j.io.pwm.PwmConfig; import com.pi4j.io.pwm.PwmProviderBase; diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/serial/RpiSerialProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/serial/RpiSerialProviderImpl.java index d3f0af3c..5d4bf323 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/serial/RpiSerialProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/serial/RpiSerialProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.serial.Serial; import com.pi4j.io.serial.SerialConfig; import com.pi4j.io.serial.SerialProviderBase; diff --git a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/spi/RpiSpiProviderImpl.java b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/spi/RpiSpiProviderImpl.java index 03d68f11..c3094b45 100644 --- a/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/spi/RpiSpiProviderImpl.java +++ b/plugins/pi4j-plugin-raspberrypi/src/main/java/com/pi4j/plugin/raspberrypi/provider/spi/RpiSpiProviderImpl.java @@ -27,7 +27,6 @@ * #L% */ -import com.pi4j.io.exception.IOAlreadyExistsException; import com.pi4j.io.spi.Spi; import com.pi4j.io.spi.SpiConfig; import com.pi4j.io.spi.SpiProviderBase; diff --git a/pom.xml b/pom.xml index 3391540b..d510421f 100644 --- a/pom.xml +++ b/pom.xml @@ -759,6 +759,25 @@ + + + org.apache.maven.plugins + maven-checkstyle-plugin + 3.5.0 + + + checkstyle-check + + check + + validate + + + + true + config/checkstyle/checkstyle.xml + **/module-info.java +