Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music quits early #15

Open
AlfredCorduan opened this issue Mar 11, 2019 · 0 comments
Open

Music quits early #15

AlfredCorduan opened this issue Mar 11, 2019 · 0 comments

Comments

@AlfredCorduan
Copy link

This is both a problem and solution. Problem: On long, more complex pieces playback quits early. Always in the same spot on the same platform, earlier if the Q: parameter is increased, less if the piece is slowed down. Solution: g.gain.linearRampToValueAtTime on line 304 of musical.js requires two parameters . . . Change

g.gain.linearRampToValueAtTime(
amp * (releasetime - starttime) / (attacktime - starttime));

to

g.gain.linearRampToValueAtTime(
0, amp * (releasetime - starttime) / (attacktime - starttime));

I am new here . . . So maybe I should have fixed it myself :-).

Thanks to Nathan Bruley for figuring it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant