Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework dev bundle patch generation to not use GNU diff #65

Open
jpenilla opened this issue Aug 18, 2021 · 5 comments · Fixed by #178
Open

Rework dev bundle patch generation to not use GNU diff #65

jpenilla opened this issue Aug 18, 2021 · 5 comments · Fixed by #178
Labels
hopefully We want to do this, but it may not be likely status: accepted Issue is accepted and we want to address it type: feature New feature or request

Comments

@jpenilla
Copy link
Member

jpenilla commented Aug 18, 2021

This is generally not very high priority as most of the time dev bundles will be generated by CI and published to maven, but it would be nice to not need GNU diff for dev bundle generation, for easier local testing on macOS (for those who for some reason don't install GNU coreutils) and Windows.

Two possible alternatives are

  • Using git to generate the patches (looked into briefly before and didn't have much luck, but I was probably missing something obvious)
  • Using Diff4j/Diffpatch/something else to generate the patches
@rgnter
Copy link

rgnter commented Mar 15, 2022

GNU DiffUtils does not have --color option. This should be marked as bug, not an "enhancement".

@MiniDigger
Copy link
Member

GNU DiffUtils does not have --color option. This should be marked as bug, not an "enhancement".

thats wrong https://www.gnu.org/software/diffutils/manual/diffutils.html#index-color_002c-distinguishing-different-context

@rgnter
Copy link

rgnter commented Mar 15, 2022

It's not available in prebuilt version 2.8.

@NotMyFault
Copy link
Member

In 10 days, 2.8 celebrates 20th anniversary. --color was originally introduced in 3.4, but you should update to the newest release from a few months ago; 3.8.
However, I'm currently on 3.7 and it works out of the box as well.

@rgnter
Copy link

rgnter commented Mar 15, 2022

It's not available standalone, after installing pacman I finally managed to get it.

@jpenilla jpenilla added the status: accepted Issue is accepted and we want to address it label Jan 31, 2023
@jpenilla jpenilla reopened this Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hopefully We want to do this, but it may not be likely status: accepted Issue is accepted and we want to address it type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants