Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle process death. #1

Open
guelo opened this issue Aug 20, 2019 · 4 comments
Open

Handle process death. #1

guelo opened this issue Aug 20, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@guelo
Copy link
Contributor

guelo commented Aug 20, 2019

Save BottomNavigator state in saveInstanceState.
@guelo guelo added the enhancement New feature or request label Aug 21, 2019
@davidbilik
Copy link

What is the current behavior on process death? Default init settings? Isnt it a leak? Because fragments are still inside FragmentManager, arent they?

@guelo
Copy link
Contributor Author

guelo commented Aug 21, 2019

Yes it's a leak. BottomNavigator will create new fragments and ignore the existing ones inside FragmentManager.

@guelo guelo added the bug Something isn't working label Aug 21, 2019
@guelo
Copy link
Contributor Author

guelo commented Aug 27, 2019

Considered several solutions and decided that in the interest of keeping BottomNavigator's API small we'll use androidx's Lifecycle Viewmodel Savedstate when it becomes available. Unfortunately that library is at version 1.0.0-alpha03 and it requires activity:1.1.0-alpha02 and fragment:1.2.0-alpha02, which means that we'll force those requirements on users of the library.

@guelo guelo removed the bug Something isn't working label Sep 3, 2019
@guelo
Copy link
Contributor Author

guelo commented Sep 3, 2019

Moved the memory leak bug to Issue #4. This ticket is for the enhancement to preserve BottomNavigator state after process death.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@guelo @davidbilik