Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bypass does not support paths containing ":" #122

Open
zoten opened this issue Feb 25, 2022 · 2 comments
Open

bypass does not support paths containing ":" #122

zoten opened this issue Feb 25, 2022 · 2 comments
Labels

Comments

@zoten
Copy link

zoten commented Feb 25, 2022

Hi everyone, and thanks for the great work!
I'm having some troubles with bypass, since I have to work with paths in the form

/a/strange/path/dotted:strange.string.that.may:happen

The problem is that both the expectation definition (hackable by using :any) and the call handling analyze the path directly using Plug's build_path_match function here, that finds the :strange.string.that.may and complain thinking it is a match's definition.

I opened a branch showing the issue with a test case here ( test )

Has anyone got any workaround for this particular case? I'd gladly try to provide a patch, if you have some indication if you already have an idea of how it could work.

Thank you!

zoten pushed a commit to zoten/bypass that referenced this issue Feb 25, 2022
@notslang
Copy link

notslang commented Feb 3, 2023

I'm running into the same issue when upgrading Bypass from 1.0.0 to 2.1.0. This wasn't a problem in older versions of Bypass.

@artemk
Copy link

artemk commented Feb 7, 2023

same issue here. Trying to tests Google Business Api, which has lots of ":requestLaunch" things in api endpoints, but looks like after this pull merged (#93) it is no longer possible.

guys you should either put some flag so that people can skip build_path_match or find out other way.
it is no sense adding features which break others' .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants