Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking modern support lacking features #1332

Open
1 of 8 tasks
Pablete1234 opened this issue Jun 19, 2024 · 3 comments
Open
1 of 8 tasks

Tracking modern support lacking features #1332

Pablete1234 opened this issue Jun 19, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Pablete1234
Copy link
Member

Pablete1234 commented Jun 19, 2024

Most if not all PGM features have been reimplemented in the newer features, with some exceptions:

  • CanPlaceOn/CanBreak: Fixed in Update dependencies to 1.21.1 #1394
    • Removed in 1.20.6 spigot/paper due to changes in vanilla.
    • Hoping to add them back when they re-add them in 1.21 or something.
  • Knockback reduction kit
    • This relied on a sportpaper only patch to set a multiplier to the kb taken
    • Can maybe be replaced with a knockback resistance attribute, since i belive that's what it does in newer versions (in older versions it was a % chance of receiving 0 kb, instead of a multiplier on kb taken)
    • If not, paper now launches an event when KB is taken and we can modify it there
  • Extra data in ping packet
    • This was also a sportpaper exclusive, we can't freely modify the ping packet to add extra data in paper
  • Observers seeing invisible players
    • sportpaper exclusive. Obs will not be able to see invisible players.
    • Maybe can get this back by modifying packets in protocol lib.
  • Hide all potion particles for players
    • sportpaper feature that PGM enabled by default on all kits who didn't explicitly disable it, only ghost squadron really disabled it.
    • Modified it so instead it will make kit potion particles ambient, no need to fully hide them.
    • Can probably get this fully back by modifying packets in protocol lib, but is a good candidate for an actual behavior change in legacy too.
  • Can't track entities spawned by dispensers (BlockDispenseEntityEvent)
    • If the spawned entity (arrow, spawn egg, tnt, etc) deals damage to someone, it doesn't count as yours for having placed the dispenser
    • This is likely very hard to work around, if at all possible
  • Can't track who caused an explosion (eg: tnt or creeper) (ExplosionPrimeByEntityEvent)
    • When you shoot a tnt with flame, or light a creeper with flint & steep, it can't count that explosion as yours
    • When a TNT you lit, makes another tnt go off, it can't count it as yours either
    • This is likely very hard to work around, if at all possible
  • EntityExtinguishEvent is missing, this should only be an internal technical issue as certain state doesn't get cleaned up, but shouldn't see feature differences.
@Pablete1234 Pablete1234 added the bug Something isn't working label Jun 19, 2024
@Brottweiler
Copy link
Collaborator

Brottweiler commented Jul 5, 2024

I hope these are relevant to this issue:

  • The icons in the settings menu are all ink sacs, probably because they use damage values but are now items.
  • potion duration="oo" should probably be made into actual infinite duration. [ref]
  • Maps previously on level 0 are no longer at the void, consider adding a setting similar to maxbuildheight that determines the lowest possible build limit.
  • Auto-learn all recipes (make sure to disable all advancements in spigot.yml.

@Mew2K

This comment was marked as resolved.

@Pablete1234

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants