Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts/Tips before the Match starts #1189

Open
arcadeboss opened this issue May 29, 2023 · 4 comments
Open

Alerts/Tips before the Match starts #1189

arcadeboss opened this issue May 29, 2023 · 4 comments
Labels
feature New feature or request

Comments

@arcadeboss
Copy link
Contributor

arcadeboss commented May 29, 2023

We can currently schedule messages "after" the game has started, but typically there are 30 seconds of time before the match where many players are paying attention where we should also be able to share an alert or tip. Some info might be best shared before the match, as opposed to the chaos of the start.

Example usage:

<alert before="15s">When the match starts, select your class at the occupation station</alert>

If an alert/tip is set for before="25s" and the system is configured for only 20 seconds pre-match delay, PGM can count this as ready to fire at 20 seconds pre-match.

@Electroid Electroid added the feature New feature or request label May 29, 2023
@Electroid
Copy link
Member

This is interesting, though I wonder how it would handle when you /start 0 or if the server's start time is less than the before filter.

@arcadeboss
Copy link
Contributor Author

I think any edge case handling would be acceptable, if generally the "standard" 30 second window would work as planned.

@Pablete1234
Copy link
Member

There's too many things that can "go wrong" here, like /start 0, or even just a /start 60 after it's already gone down 25 (meaning repeated messages?), etc.

Honestly i'd rather make it be messages that appear when joining the match (like the maps' name & objective is shown on cycle)

@arcadeboss
Copy link
Contributor Author

The last thing you mentioned sounds good to have.

With the edge cases on my suggestion, I would suggest disabling the "before" messages. For example, there can be a flag if any "before" messages have fired yet, and if so then no more would be displayed when reset of start occurs. If none had been displayed, it would be safe to display them all.

For game starts with no pre match period, they would not be processed or displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

No branches or pull requests

3 participants