Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Discontiguous selection is not supported error" in Chrome #182

Open
deeknow opened this issue Nov 18, 2015 · 8 comments
Open

"Discontiguous selection is not supported error" in Chrome #182

deeknow opened this issue Nov 18, 2015 · 8 comments

Comments

@deeknow
Copy link

deeknow commented Nov 18, 2015

(customer report) "You might want to warn users about this. Relevant to 'Range.detach' is now a no-op, as per DOM" and "Discontiguous selection is not supported." errors when loading a page with 0 dependecies package"

@deeknow
Copy link
Author

deeknow commented Nov 18, 2015

Reopening issue which was reported in #176 originally. Testing showed the error was presenting itself in Chrome only. Recommended fix is to update the Rangy JS lib as the author has now implemented a solution for the Chrome behaviour (which is apparently throwing an error when it shouldn't)

fix will be applied to the raptor-dependencies repo which is cloned as part of the standard raptor-editor build process

@Petah
Copy link
Contributor

Petah commented Nov 18, 2015

#176

@deeknow
Copy link
Author

deeknow commented Nov 18, 2015

thanks Petah: going to push the 1.3 final release of Rangy to the dependencies sub-project

@Petah
Copy link
Contributor

Petah commented Nov 18, 2015

It wont work out of the box as there was some mods made to Rangy

@deeknow
Copy link
Author

deeknow commented Nov 18, 2015

There's no history of the mods by you in the -dependencies project. Realise this was awhile ago but any idea when it was roughly that the rangy code was last pulled from Tim. I see there's a build date of 22/Feb/2014 but don't see a tagged release from him at that time for 1.3a, maybe some of the history got lost when his project was migrated over from Google code? Would be great to get a date then we could do a diff and see what was changed by you, that way Rangy can move forward in future if required.

@Petah
Copy link
Contributor

Petah commented Nov 18, 2015

Here is some of them: https://github.com/PANmedia/raptor-editor/commits/master/src/dependencies/rangy/rangy-cssclassapplier.js

The raptor-dependencies repo was split out of the main repo, so log will be in there if you search for them.

There is also this: https://github.com/PANmedia/raptor-dependencies/blob/master/rangy/rangy-applier.js which I think might have been custom, not sure though. Not sure where/if its used either.

@deeknow
Copy link
Author

deeknow commented Nov 18, 2015

Great stuff. I'll take a squiz and see how much effort is required to patch that over the 1.3.0 final release. And yeah rangy-applier looks to be based on cssapplier but is a new custom file altogether so I'll assume it can be left as is for now. Thanks again.

@Gregg8
Copy link

Gregg8 commented Mar 23, 2016

Any progress on this? The error can cause issues if you have unhandled exception detection software that logs to a third party service. You end up getting many unnecessary log entries. Any work arounds apart from patching the code would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants