Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes oxalis-outbound/src/main/java/network/oxalis/outbound/transmission/DefaultTransmissionRequest.java and DefaultTransmissionMessage.java implement Serializable but use not serializable fields #688

Open
IacopoArduini-gmail opened this issue Oct 8, 2024 · 0 comments
Labels
Under review Issues currently being reviewed

Comments

@IacopoArduini-gmail
Copy link

Dear OxalisCommunity,

we just ran an automated CAST analysis on Oxalis codebase and, among other violations, we found out this specific one: the two classes mentioned in the object of this issue implement the Serializable interface, but use as a field the Object InputStream that is not serializable. This is not an immediate problem since both classes are not actually serialized anywhere in the software, but declaring non-transient fields of non-serializable type inside of a serializable class will result in an exception thrown during the serialization. This issue can prevent the software from running reliably, e.g. by triggering an exeption. If the relevant code is reachable by an attacker, then this reliability problem might introduce a vulnerability.

As a suggestion, if those classes don't actually need to be serializable, they could just not implement the Serializable interface, and this would solve the violation.

Best Regards,
Iacopo

@aaron-kumar aaron-kumar added the Under review Issues currently being reviewed label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Under review Issues currently being reviewed
Projects
Status: Open Issues- Review Required
Development

No branches or pull requests

2 participants